Merged
Conversation
rkistner
reviewed
Feb 13, 2026
Contributor
rkistner
left a comment
rkistner
left a comment
There was a problem hiding this comment.
Is it feasible to add a test for the generated SQL? Even if it's just a Rust unit test rather than an "end-to-end" Dart one.
simolus3
force-pushed
the
infer-raw-table-statements
branch
from
bd4886d to
7e1a6a7
Compare
Contributor
Author
We can pretty much only test this in Rust because the statements are internal to the extension and not exposed. I've added tests at the end of |
rkistner
previously approved these changes
Feb 16, 2026
simolus3
force-pushed
the
infer-raw-table-statements
branch
from
b7af9ba to
9d54a31
Compare
rkistner
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of the new raw table options introduced in #163.
This makes the
putanddeletestatements set on raw tables optional. If they're omitted, thesync_localstep of each sync will attempt to infer them by looking at the actual columns of the table:idcolumn will be set to the affected row id.Inferred statements are cached until
pragma schema_versionreturns a new value.For now, this does not support a dedicated
_restcolumn that would be inferred by default. Users interested in that would have to use explicit statements instead.